Elena Felder

Results 82 comments of Elena Felder

For posterity, the issue is not Firestore-specific, but adding metrics following [Spring Boot docs](https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#actuator.metrics.registering-custom) avoids the cycle nicely. In the reproducer, user implementation of `MeterBinder` inserted itself in the middle...

For completeness; here is a reproducer without Firestore: https://github.com/elefeint/FirestoreMetricsReproducer/tree/h2-reproducer

@meredithslota Cloud Spanner Hibernate dialect for version 6 exists and lives in the [Hibernate repository](https://github.com/hibernate/hibernate-orm/blob/main/hibernate-core/src/main/java/org/hibernate/dialect/SpannerDialect.java), unlike the Hibernate dialect for version 5.5, which lives under [GoogleCloudPlatform](https://github.com/GoogleCloudPlatform/google-cloud-spanner-hibernate/). The upgrade from Hibernate...

Was `ObjectAppendingMarker.getFieldValue()` never meant to be public API? We relied on it, perhaps incorrectly, to [enrich logging data with Logstash markers](https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/v3.2.1/spring-cloud-gcp-logging/src/main/java/com/google/cloud/spring/logging/extensions/LogstashLoggingEventEnhancer.java#L50).

The enhancer is an optional add-on that adds Logstash markers as log metadata for logs written to GCP Cloud Logging. So as long as we have a way to extract...

spring-cloud-gcp glues together Logback and GCP abilities -- in this case, logback's [`JsonLayout`](https://github.com/qos-ch/logback-contrib/blob/master/json/classic/src/main/java/ch/qos/logback/contrib/json/classic/JsonLayout.java). `JsonLayout` accepts a map of keys and values, but not raw JSON.

There were 3 issues that blocked upgrade: 1) premature end of chunk coded message body -- fixed in googleapis/google-http-java-client#1427 2) certificate issue with docker containers stored on AWS S3 https://github.com/aws/aws-sdk-java/issues/1919...

Thank you for the investigation and detailed notes!

@chanseokoh Should we file this issue in https://github.com/GoogleContainerTools/jib-extensions instead? Or do the existing Spring Boot extensions address this usecase?