elParaguayo
elParaguayo
According to https://github.com/qtile/qtile/issues/3337, there is no double counting of margins in the xmonad layouts. I'll look at your code properly later on but I've started the tests in the meantime.
Re double counting: if a user sets a margin of `5`, I would not expect to have a gap of `10` between windows.
I've made some suggestions which would remove some unnecessary calculations. I haven't tried this code yet though but will run the rest suite to see if the current tests still...
Nice! My personal feeling on `migrate` scripts is that I don't particularly like them. I'm all in favour of trying to prevent breakages for users but: - I'm sceptical as...
> Thank you for the feedback, @m-col @elParaguayo! Do you mind if you can point me where exactly example of phased deprecation is in the codebase? Here's an example where...
> > It looks like bowler is not supported past python 3.8 so may be incompatible with some users' configs. > > To be precise, bowler is no longer adding...
OK - I've just tried this patch and there are a few bugs. I'll post some comments later. We might want to add some more tests to make sure the...
Thanks. I am a bit confused, though. Why was the test passing previously without this change? I imagine python would have joined those two strings but they would have been...
This line: ``` ValueError: RGB specifier must be 6 or 8 characters long. ``` is the error I would have expected to see but it's passed on previous CI builds....
#3544 (if it gets merged) will mean we can keep the 3 character hex colour values.