Ertugrul Karademir
Ertugrul Karademir
> What type of exception is this one? will it be falling under base exception @ekarademir > > https://github.com/accordproject/concerto/blob/abd1c8ee15711ba0cea99a2476fbf01650a05fd4/packages/concerto-core/lib/introspect/property.js#L181-L184 Usually `IllegalModelException `
Cases I found that are considered `no change` by the analyser: - Adding a default value to a scalar - Removing a default value from a scalar - Changing the...
* Changing argument list of a decorator of a property * Adding a decorator of a property * Removing a decorator of a property
The culprit here is that while `fromAst` populates the manager with model files, it [doesn't provide](https://github.com/accordproject/concerto/blob/c5f5e2e1476e260803893cb9b2faf7814e684a3e/packages/concerto-core/lib/basemodelmanager.js#L756) [`definitions`](https://github.com/accordproject/concerto/blob/c5f5e2e1476e260803893cb9b2faf7814e684a3e/packages/concerto-core/lib/introspect/modelfile.js#L83-L86). However `getModels` [relies on](https://github.com/accordproject/concerto/blob/c5f5e2e1476e260803893cb9b2faf7814e684a3e/packages/concerto-core/lib/basemodelmanager.js#L509) `definitions` being there. Otherwise `fromAst` and `getAst` operations are...
Have a look into this @subhajit20 https://github.com/accordproject/concerto/pull/773
This has to be generated from the JSDocs. Otherwise this change will get overwritten @subhajit20
Some test cases to consider ``` import com.example.foo.{as as as} ``` ``` import com.example.foo.{As as as} ``` ``` import com.example.foo.{Document as Doc1, Doc2} import com.example.bax.{Document as Doc2} ```
@dependabot rebase
@dependabot rebase
@dependabot rebase