Eirikur Jonsson

Adjusting/refactoring ADflow to eliminate this completely I think will be difficult since there will likely always be some "inconsistency" where the slice cuts through the grid/states. This depends on the...

@gang525 since I missed the discussion, can you add a little more detail on what other methods you discussed and then specifically how approach this is supposed to work. I...

@nwu63 I can have a look at the remaining issues as I wanted to update the complex build anyway.

Yeah, I think this is good for now. Will mark it ready for review. Few things to note. I created an interface for `myisnan` to handle both the real and...

@sseraj I agree, this is a bit much of a regression for my liking. The `returnFail` should handle this. Do you have a MWE that I could check.

Ahh, of course, I forgot about this flag. This makes sense. Any check for NaN will not work with this flag, as enabling will turn on `-funsafe-math-optimizations, -ffinite-math-only`, so NaNs...

@nwu63 sure we have a broader discussion on this, especially for production runs. I am somewhat mixed on this. Using `-O3` should probably be fine, but I am more worried...

Right, yes, I would prefer a consistent behavior if possible. Alright, I will make some changes.

I pushed a proposal to allow `-ffast-math` flag to be used without altering NaN behavior to a separate branch and made a PR here https://github.com/mdolab/adflow/pull/233. Decided to make this a...

I can approve this but, since I made large amount of changes, I would prefer that someone else reviewed, tested, and gave some feedback. @anilyil @joanibal?