Chris Travers comments

Results 49 comments of


                                            Chris Travers

BZ #127: Bucardo Fails to add table if db doesn't have password. Ignores pgpass file

I have monkey-patched this in production. The specific problem here is that we are forcing a password in, while it should be set to undef if no password found.

Recommendation: set session_replication_role only if user is superuser

Actually as I think about it a better option would be to set this as a configuration on the sync. We set it so that we can do things like...

Recommendation: set session_replication_role only if user is superuser

hmmm this could impact foreign key checks. Need to think more.

Bucardo status json and zabbix output format to simplify monitoring without extra dependency.

I like these changes.

1.3->1.5 migration fails on "not the latest" 1.3 schemas. Same for 1.2->1.5

for 1.3, we need to know what the fixes.sql is before we install so maybe we should just copy that file in and run it first? For 1.2, we had...

1.3->1.5 migration fails on "not the latest" 1.3 schemas. Same for 1.2->1.5

I really don't want to recreate the 1.2 upgrade logic going forward :-) but 1.3 could use running the Fixes.sql first if we keep that current.

Add printed invoice as attachment in the database

I don't think that is the right soltuion. I think a better one would be to attach the printed file to the invoice.

Add printed invoice as attachment in the database

I don't know that this solves all the problems though. Currently we do not store all data that goes into rendering the template in the invoice tables of the database....

Use AR Overpayment cannot 'X' remove unused Invoices, therefore can't post

Also if works if you x the bottom line strangely.

Use AR Overpayment cannot 'X' remove unused Invoices, therefore can't post

At present the code here is pretty opaque. I don't see this as something that is a quick fix. Workarounds are: 1. Post without updating, or 2. Also click the...