Eric Huss

Results 862 comments of Eric Huss

I'm opening this up as a draft to get some feedback to see if this is a worthwhile direction to go. This is something I've wanted for a while, as...

@epage or @weihanglo, I'd like to move forward with this. Would either of you be willing to review this? I updated it for the latest master. There are also some...

This seems to be a very unusual way of stabilizing something. Can you clarify exactly how this is intended to work? I'm skeptical that our setup can handle stabilizing in...

This does seem to actually stabilize it, though, in the sense that there is no longer a `-Z` flag to gate it. Cargo specifically has a system to make things...

Can we move all of the docscrape tests to a separate module? Having `doc.rs` climb past 3,000 lines is making it a bit too heavy-weight, and it can be convenient...

There doesn't seem to be anything that will enabling scraping of targets with `doc-scrape-examples=true` set (or to disable it if `doc-scrape-examples=false`). I see that may be difficult to implement because...

Thanks! We discussed this and feel like just using negative numbers should be fine. Just a minor change and I think it should be good to go.

It is unrelated to JSON which uses a separate code path (only if `--message-format=json` is used). It is buffered so that when multiple compilers are running at the same time...

Thanks for the suggestion! This is essentially a duplicate of #9652. However, since this has more detail I'll close the other issue. However, #9652 contains a few different experience reports.

Another thought I had that would be useful (unrelated to `+toolchain`) is to also print a note, recommending the user run `cargo --list` to get a complete list of subcommands....