Emma Hogan

Results 11 comments of Emma Hogan

I had a question about this :) Does it make sense to add global attributes and variable attributes, which I would argue are netCDF-specific concepts, to the cube, which is...

@taylor13 are you remembering the discussion we had about `CMOR_PRESERVE` on #246? :)

Adding `"_cmip6_option": "CMIP6",` to the `cmor_dataset` JSON file only improves this slightly: - `source` replacement is logged - `experiment_id` is checked - `grid_label` is checked

Adding the appropriate values for `experiment_id` and `grid_label` improves this further: * `activity_id` is replaced and logged * `experiment` is replaced and logged * `source_type` is checked (but doesn't cause...

Sure :) [cmor_dataset_json.txt](https://github.com/PCMDI/cmor/files/2779832/cmor_dataset_json.txt) I started with an empty file and added attributes (with initial values equal to a letter in the alphabet) when CMOR reported they were required. I then...

Thanks Karl :) The `_AXIS_ENTRY_FILE` and `_FORMULA_VAR_FILE` attributes have default values available in [cmor.h](https://github.com/PCMDI/cmor/blob/master/include/cmor.h#L101). I can add the `mip_era` with a random value and it is completely ignored (I think...

With regards to the `further_info_url`, a minimum value of `https://furtherinfo.es-doc.org/` is required, since it is checked against the CVs [here](https://github.com/PCMDI/cmip6-cmor-tables/blob/master/Tables/CMIP6_CV.json#L9100). Also, I note that [CMOR_DEFAULT_FURTHERURL_TEMPLATE](https://github.com/PCMDI/cmor/blob/master/include/cmor.h#L263) exists; could CMOR use this...

The CF conventions state that `Missing data is allowed in data variables and auxiliary coordinate variables` (see http://cfconventions.org/cf-conventions/cf-conventions.html#missing-data). This warning message occurs when using data containing auxiliary coordinate variables, so...

Thanks @bjlittle :) I'm happy with the discrimination between `np.float(89.5)` and `89.5`. I do think it would be super helpful if the output showed the types of the values, as...

> If this issue is still important to you, then please comment on this issue and the stale label will be removed. This issue is still important to me 😊