Ergels Gaxhaj

Results 20 comments of Ergels Gaxhaj

Closed by accident.

> I agree with @marbar3778's first comment up top. Since these are plugins, they should be optional additions instead of required tag-a-longs. This is primarily an issue with the kafka...

> could we use hashicorup-plugins and replace all the current code? Yes, I'll work on a PR using the hashicorp-plugin to see how well it fits with what we want...

> > could we use hashicorup-plugins and replace all the current code? > > Yes, I'll work on a PR using the hashicorp-plugin to see how well it fits with...

> @egaxhaj following up on this. do you need some help in pushing this over the finish line? I was wrapping up work that prevented me from looking at this...

@yihuang very nice clean up on the rootmulti. The cache layer is still a puzzle for me. @yihuang @peterbourgon @alexanderbez I'm unclear on needs to be captured. Do we not...

> > @yihuang very nice clean up on the rootmulti. The cache layer is still a puzzle for me. > > @yihuang @peterbourgon @alexanderbez I'm unclear on needs to be...

> > I know the block they belong to so I write them out to the plugin. I can also handle the stopNodeOnErr scenarios. Is this wrong? Do we need...

> > ABCIListener looks as follows: > > ```go > > // ABCIListener is the interface that we're exposing as a streaming service. > > type ABCIListener interface { >...