Efe comments

Results 21 comments of

Efe

Test failing on Node v20.x

Should we close this? The tests are passing

Support diagnostic channels

Hi @dohrisalim, as Wesley already mentioned, feel free to open a PR with your implementation.

fix: correct broken German middleware link

[The link looks fine to me](https://expressjs.com/de/guide/using-middleware.html), are we sure it's broken?

Performance optimization opportunities for CORS middleware

Thanks for raising this issue. Some of the micro optimizations you mention might be worth exploring, but we need benchmarks to justify the changes. However, keep in mind, we need...

Performance optimization opportunities for CORS middleware

Looks like the author mostly creates AI slop issues/PRs, I'm closing this down.

fix(res): handle null maxAge gracefully in res.cookie() and updated the dependency "cookie" to the 1.0.2 latest version

Thanks for the PR! This PR feels a bit off, as far as I can see `maxAge: null` already works fine. I think you are self introducing a regression by...

fix(res): handle null maxAge gracefully in res.cookie() and updated the dependency "cookie" to the 1.0.2 latest version

Hi @SaisakthiM, I'd say I've made my points already about the PR. Let's wait for others to chime in. Let's not tag them directly, though, because the team is really...

fix: log error cause chain in logerror function

Thanks for your contribution! Noticed that #6464 also solves the same issue, would it make sense to collaborate there instead of having two fixes? That way, the maintainers would review...

docs: update migration guide with send.mime change

Thanks for the PR! It looks like you removed 501 lines, and added none with your last commit :)

Add comment for app.get() method usage

Thanks for the PR! IMO it could be helpful to have some comments in the hello world example, but I'm not sure if this particular comment is helpful. Maybe you...