Ethan Peterson
Ethan Peterson
@shimwell I really like this! My first bit of feedback is that I think having a single json file for each library may be clearer and I think the method...
@paulromano and @shimwell I have been thinking about this a little lately and I think this might warrant just a little more structure to do robustly, namely a `MaterialLibrary` class...
@shimwell I think we need to move the library file to `material_libraries/pnnl_v2.json` to fix the failing test
Would this potentially be a reason to move to a single `model.xml` input file that has elements comprised of the existing necessary XML input files? To me this seems a...
@paulromano I think PR#1990 is a good work around if we want to address this immediately. In the single `model.xml` file paradigm, I would be supportive of another subsection for...
Hi @cfichtlscherer thanks for posting this! We are actually working on something along these lines and this brings up another reason why we should put together a regular dev meeting...
I don’t quite see how not including widely used libraries within OpenMC directly helps with QA exactly and to me it doesn’t make sense for something like the PNNL compendium...
Thanks very much for submitting this @Empi93! @shimwell raises a number of good points. It would be good to integrate this into the existing methods and change their names accordingly...
@paulromano this looks good to me so far. I think the small amount of Cython used in the repo should be fine because it was using Cython > 3.0. I...
@caderache2014 I don't think either of us is going to tackle this in the near term so feel free! if you have any questions let me know.