Ed Burn comments

Results 9 comments of


                                            Ed Burn

Feature request/Question: do not drop extra classes (and attributes) with functions group_by, summarise and so

Just wondering if there is any potential resolution to this @hadley. In the link mentioned above, https://dplyr.tidyverse.org/reference/dplyr_extending.html it also says "These functions are a stop-gap measure" so I'm not sure...

SQL's LIKE is actually case sensitive

@hadley I wonder whether instead of changing the default of ignore_case, what about introducing a new function: `str_ilike()`? Then stringr could have two functions - str_like - similar to SQL...

SQL's LIKE is actually case sensitive

@hadley I have opened pr #544 with a str_ilike function and the ignore_case argument in str_like deprecated

str_like case sensitivity

@hadley @mgirlich just fyi I noticed this pr had a merge conflict so I have resolved that

Possible inconsistency in translation of stringr::str_like() with respect to ignore_case argument

I'd be happy to work on a pr if you think this is a bug

Possible inconsistency in translation of stringr::str_like() with respect to ignore_case argument

Hopefully not too presumptuous, but I opened this pr #1490 that would switch the behaviour around

postition of head in pipeline no longer leading to different sql

Interesting. I suppose throwing a warning if head is included in a complex query might be appropriate? The desired behaviour (well at least what I was thinking was desired) can...

Error in stopifnot(is.character(filename), length(filename) == 1L) : reached elapsed time limit

@catalamarti it seems the problem comes from this line https://github.com/tidyverse/tibble/blob/6f5c3af47657576eeefdba0ad15edab07fe3f028/R/str.R#L11 (if I bring the package locally and comment these lines out this warning/ error no longer appeared) To fix in...

Error in stopifnot(is.character(filename), length(filename) == 1L) : reached elapsed time limit

@krlmlr I´m not sure if this issue should be closed as is or if some input validation can be added to str.tbl_df (it took some digging to work out what...