Edvard Chen
Edvard Chen
@targos is there any way to see the error details? And had it succeeded?
> Not yet, we'll also need to skip all big-endian platforms as that's currently not supported. The `git diff` related tests failing is a bit odd. is there any way...
@targos I think we are ready for another CI round
@arcanis reasonable. Let me turn on the `flaky` field for all machines
@targos do you mind giving it another CI round?
1. Another frequent error we might be able to improve is that git on the testing machine like `debian9-64` or `debian9-64` didn't support option `--ignore-cr-at-eol`. Is there any way to...
> I think we need to skip Windows too. Snapshot tests are failing, probably because of CRLF. not only windows. That test case uses `--ignore-cr-at-eol` to ignore carriage-return differences. But...
@targos hi, no mean to push you, but is there any concern about upgrading the git client to a version that support `--ignore-cr-at-eol`?
I think there are 2 approaches we can try at yarn side 1. make the [diffFolders](https://github.com/yarnpkg/berry/blob/d1961eed503835a78ae82c33e48986dfdbbf92ff/packages/plugin-patch/sources/patchUtils.ts#L279) compatible for those git versions that don't support `--ignore-cr-at-eol` 2. Or, ignore the [diffFolders.test.ts](https://github.com/yarnpkg/berry/blob/master/packages/plugin-patch/tests/diffFolders.test.ts)...
@RickWong