Ed Tanous

A basic example is below. Both tests for return_type and args produces. ``` error: no type named ‘type’ in ‘struct boost::callable_traits::error::return_type::_ ``` It's not clear if this is intentional on...

https://github.com/chriskohlhoff/asio/blob/147f7225a96d45a2807a64e443177f621844e51c/asio/include/asio/ip/network_v4.hpp#L54 The above is a constructor that allows constructing a network_v4 object from an address and a subnet mask. The constructor has some non-trivial parsing code to ensure that the...

OemSession implements "client id" which is already covered in standard

4

OemSession implements a new field, ClientId, which in practice is perfectly analogous to session id (the resource id itself). It's not clear why this extra unique ID was added, but...

**Describe the bug** ``` WARNING: bmcweb-1.0+gitAUTOINC+a170f27567-r0 do_package_qa: QA Issue: File /usr/bin/.debug/bmcweb in package bmcweb-dbg contains reference to TMPDIR [buildpaths] ``` gets printed to the console when doing bmcweb builds. This...

hypervisor routes are installed on systems that don't have hypervisors

3

Since commit 462023addac00b521fc2e59ae53080046438ddfa the /redfish/v1/systems/hypervisor routes have been showing up in the systems collection for all systems. Considering the majority of systems don't have a hypervisor present, these nodes should...

Redfish collections don't implement the /Members route

1

**Describe the bug** bmcweb Redfish collections appear to be modeled incorrectly according to the specification. Because the Members property within a collection is simply a list of resource references, with...

Dead virtual media code in bmcweb

19

The nbd proxy implementation present within bmcweb never had it's backend upstreamed. As such, this is dead code to us, and could be removed. Code in question is here: https://github.com/openbmc/bmcweb/blob/master/include/nbd_proxy.hpp...

https://github.com/openbmc/bmcweb/blob/65f7365901fad2437456f4edcdac41e03f0ca259/static/redfish/v1/schema/OemAccountService_v1.xml#L65 CSDL abstract classes work like Java abstract classes, they can't be created directly, only inherited from. We should have an inherited class that we version properly, identical to how...

The existing OEM manager schema needs broken out into the appropriate resource schemas for pid controllers fan controllers, and stepwise controllers, with appropraite entity types for each. When James first...

OEM schemas should be versioned identically to how redfish schemas are versioned. This is required, because any changes going forward would be client breaking changes otherwise. Example of unversioned schema:...