Edon Gashi

Results 54 comments of Edon Gashi

I read this icon workaround somewhere and it worked for me: `config-overrides.js` ```js const path = require('path') const { override, fixBabelImports } = require('customize-cra') module.exports = override( fixBabelImports('import', { libraryName:...

@jannikbuschke I can't remember and couldn't find it online either. Maybe it's in older commits because as you noted, they are changing the approach. I uploaded the file here: https://gist.github.com/edongashi/25472166af75197287bd62d14d654363...

Also worth mentioning that I still had issues with bundling while using this library. Treeshaking wasn't working - it was importing a ton of things from antd without ever using...

Sounds great. I'll keep an eye for 1.4 and do a cleanup for these things. If I find anything useful I will update. Thanks!

It's weird considering the package has sideEffects=false. Some import somewhere is sticking the modules together.

@thj-dk is your build script in `package.json` set to `"build": "react-app-rewired build"`? Also try setting `style: 'css'` in `fixBabelImports` to see if it makes any difference.

I found the problem. This library has `"sideEffects": false` whereas ant design has ```json "sideEffects": [ "dist/*", "es/**/style/*", "lib/**/style/*", "*.less" ] ``` Marking all files as side effect free tells...

Hmm, I'm not sure. This library does not expose any `.less` files. so I don't know whether adding the ".less" string to sideEffects would have any effect. Could you try...

I tried to reproduce this issue with ```js modifyVars: { "layout-body-background": "yellow" } ``` but it works on both dev and prod builds. Do you have an `@import` statement somewhere...

Hi @KrisJanssen! > The fact that the demo apps are included to not only demonstrate Forms but also the application piece (e.g. the routing) is nice. I'm glad you found...