edmondchui

Results 9 issues of edmondchui

In the file https://github.com/jacopotarantino/angular-match-media/blob/0.6.0/bower.json, the version is 0.5.0. Is that a typo or a wrong version? Please fix for version 0.6.0. Thanks.

I got the following error when trying to upgrade from version 1.2.1 to 1.4.0 via `bower install` ``` bash $ bower install bower angular-localization#1.4.0 not-cached git://github.com/doshprompt/bower-angular-localization.git#1.4.0 bower angular-localization#1.4.0 resolve git://github.com/doshprompt/bower-angular-localization.git#1.4.0...

What is the specific reason for that? Other spree core models all inherit from Spree::Base.

In the [pull request for Spree 4.5 update](https://github.com/spree-contrib/spree_reviews/pull/197), `spree_frontend` gem was introduced as a gem dependency. Since I don't use `spree_frontend`, I got following error when starting my Spree server:...

Resolve [issue#201](https://github.com/spree-contrib/spree_reviews/issues/201)

Resolve [issue#198](https://github.com/spree-contrib/spree_reviews/issues/198): - Remove `spree_frontend` gem dependency.

Got this warning with Spree 4.6.1 running on Ruby 3.2 and Rails 7 ``` /Users/echui/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/spree_reviews-36ef2809191c/config/initializers/spree_permitted_attributes.rb:3: warning: already initialized constant Spree::PermittedAttributes::ATTRIBUTES /Users/echui/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/spree_core-4.6.1/lib/spree/permitted_attributes.rb:3: warning: previous definition of ATTRIBUTES was here ```

Add a clear button at the end of the search input field to clear the search query upon clicking. The clear button will only appear when the search query is...

enhancement

In Rails 7, running `zeitwerk` check gives the following error ```shell $ bin/rails zeitwerk:check /Users/dev/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/spree_reviews-36ef2809191c/config/initializers/spree_permitted_attributes.rb:3: warning: already initialized constant Spree::PermittedAttributes::ATTRIBUTES /Users/dev/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/spree_core-4.6.6/lib/spree/permitted_attributes.rb:3: warning: previous definition of ATTRIBUTES was here rails aborted!...