Edil Medeiros

Results 31 comments of Edil Medeiros

I have not tested the new version myself (yet), but it seems https://github.com/BlockchainCommons/Community/issues/140 solved this. So, I believe the two warnings in the text ([this](https://github.com/BlockchainCommons/Learning-Bitcoin-from-the-Command-Line/blob/9b97c50471226fc8fdb6063508c75db156bf5122/16_1_Accessing_Bitcoind_with_C.md?plain=1#L9) and [this](https://github.com/BlockchainCommons/Learning-Bitcoin-from-the-Command-Line/blob/9b97c50471226fc8fdb6063508c75db156bf5122/16_1_Accessing_Bitcoind_with_C.md?plain=1#L29)) are adding noise...

I confirm this. I installed libmutiprocess manually; I'm not using what's on `depends`, but it generates the same error. Moreover, I tried on the current master head (03c5b006) and build...

Tested ACK. I was watching the issue in chaincodelabs/libmultiprocess#92 and confirmed the fix in chaincodelabs/libmultiprocess#93. I built and executed bitcoin-core tests with this PR following the official setup with Brew....

How are you getting the dependencies? I just compiled it in a box with Brew following the official instructions, and I could build it. When using a box with Macports,...

All right, better than my review would be to convert this to a scripted diff as you are doing in #29500.

> Thanks for the review @edilmedeiros, some of the existing BOOST_CHECK_MESSAGE messages are either in [indicative](https://github.com/bitcoin/bitcoin/blob/master/src/test/bloom_tests.cpp#L51) or [subjunctive](https://github.com/bitcoin/bitcoin/blob/master/src/test/bloom_tests.cpp#L31) grammatical moods (even in the same file, as you can see). I'm...

I like the idea. Another idea would be to have a/the bot to automatically tag the PR with `insufficient review` if it gets stalled for a few weeks, before closing...

Force pushed so that the commit message is the same as the PR title.

A small caveat: I couldn't get rid of the `Could not satisfy difficulty target` message (see the debug log just before timestamp `2024-05-17 12:56:01`). This is emitted by `bitcoin-util` itself...

Thanks for the review, @AngusP. Your suggestion did the trick, indeed. Log from mining two blocks. The first exhausted the grinder search space. The second didn't. ```bash 2024-05-20 15:05:53 INFO...