Ed Bentley

Results 12 comments of Ed Bentley

@mesqueeb I just meant that it wasn't worth moving the existing JSDoc comments to the interface since they still won't show.

This could also be implemented with a [Native Sprite](https://replay.js.org/docs/native-sprites/) first before going into the library, e.g.: ```js GamePad({ id: "NativeGamePad", sprites: (gamePadInput) => [...] }) ```

Hi @brillout, thanks for the suggestion. I’m curious, what does this do that this package is lacking? Is it that you’re able to reference an existing type?

@brillout Right your example looks exactly as I would like to have it too, very nice! The problem I've had is filling in the type of `Todo` requires some sort...

As far as I’m aware (please correct me if I’m wrong), the Babel transformer knows the name of the type used, but it can’t look up its value. I’d love...

I think you’re right, thanks! I hadn’t started on this, but will use that resource for sure when I do. 🙂

This will be really helpful to have! react-devtools mentions [it uses a global `__REACT_DEVTOOLS_GLOBAL_HOOK__`](https://github.com/facebook/react-devtools/tree/b370497ba6e873c63479408f11d784095523a630#faq), you can sort of see how that works [here](https://github.com/facebook/react/blob/08c1f79e1e13719ae2b79240bbd8f97178ddd791/packages/react-devtools-extensions/src/injectGlobalHook.js). So replay-core won't put anything on the...

You can satisfy TypeScript by adding `"DOM"` as a lib here: https://github.com/edbentley/replay/blob/b77054071adf1a886c57f054fcb072f39df56439/packages/replay-core/tsconfig.json#L5 But replay-core isn't guaranteed to run on the web so this isn't ideal. I'd suggest using [globalThis](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis) instead....

I don't quite understand why some pixels are wider. Shouldn't you just have a greater width / height margin with a fixed size image? And what's the difference with this...

This could be a relatively easy change if added in to options in replay-web here: ;) https://github.com/edbentley/replay/blob/v0.8.0/packages/replay-web/src/index.ts#L82