Emerson Coskey

Results 22 comments of Emerson Coskey

dunno why this is still open. This effort is shelved for now.

I'll get around to a full review tomorrow probably. But like @hymm mentioned adding the `ResMut` to every system breaks our parallelism. Since commands are sequential anyways, could we have...

Would we have to do any extra shenanigans to add a RenderId component in the main world compared to a MainId component in the render world? I did a little...

> How does `MainId` work? is there a fast way to do the mapping? The trick would just be to do the mapping during command application so we avoid extra...

Terminology: sub-scenes are the bsn equivalent of prefabs from other game engines, with similar(but not the same) considerations. Specifically they’re bsn `include`s (from what I can tell from the proposal)

What's the difference between the radiance and irradiance maps here? I skimmed the linked blog posts and don't really see where irradiance comes in. Am sleepy though so that might...

> Would you like reviews/feedback on this at this stage or is it too early? The structure of everything is pretty much final so feedback on that would be nice...

> Considering the `Atmosphere` takes parameters about the inner and outer radius of the atmosphere, maybe it would make sense if that component was an another entity? That would allow...

> > Some of the main assumptions made > > I thought the Hillaire paper explicitly allows for space views of the atmosphere? Anyway, I totally understand if it is...

Gonna put this up for review, I know the sunrise/set colors aren't perfectly accurate, but I've been unable to fix it. I'd be perfectly fine merging this as an experimental...