Ed Catmur
Ed Catmur
> The frozen set casters are a decent idea, but I don't know how I feel about the tuple ones considering we have std::tuple to fulfill that role already. I...
> I tried the branch and get multiple errors during compilation on my Mac: > > > error: ambiguous partial specializations of 'type_caster' const_name("FrozenSet[", "Set[") + key_conv::name Oh, sorry. Maybe...
> I looked up and down both PRs quite a bit, but didn't get a chance yet to fully appreciate all details. It looks very interesting: not a lot of...
> Hi @ecatmur is this ready for re-review? (Or are you still working on it?) Sorry, yeah. I was exploring some alternate approaches (I don't particularly like `frozen_type_name`) but nothing...
I'm not sure whether this is correct, but possible workaround: ```python Bonsai_capnp = capnp.load(file_name="Bonsai.capnp", imports=[os.path.dirname(p) for p in capnp.__path__]) ```
Ah, yeah - clang is stricter on placement of the attributes. I'll have to make KJ_WARN_UNUSED_RESULT a wrapper macro, rather than a suffix. Will try to post a fix soonish.
note: introduced by Clang in https://reviews.llvm.org/D71576
@raffienficiaud thanks, I've tested and I still need the change for comparisons to work. I've rebased my patch and force pushed. My commit is the last one, https://github.com/boostorg/test/pull/242/commits/50826175f8fd19e94fb85ac4db3de31fed3f74a0
> Are there any benchmarks? The only benchmark that is affected by this change is bench/buffers; I ran the benchmark (Ubuntu gcc 9, x86-64, release, threading-multi) but didn't observe any...
see: https://reviews.llvm.org/D119670