Éamonn McManus

The idea isn't unreasonable. We already have [`put(Map.Entry)`](https://javadoc.io/static/com.google.guava/guava/31.0.1-jre/com/google/common/collect/ImmutableSetMultimap.Builder.html#put(java.util.Map.Entry)) methods in `ImmutableSetMultimap.Builder` and `ImmutableListMultimap.Builder`. On the other hand, `Map` doesn't have a `put(Entry)` method, though your argument would seem to apply...

This does seem wrong. I think [here](https://github.com/GoogleCloudPlatform/functions-framework-java/blob/e7dea60fd829e5ce08ee8066fcc4f96b03f7dcf0/invoker/core/src/main/java/com/google/cloud/functions/invoker/http/HttpRequestImpl.java#L120) we should change the code from this: ``` .collect(toMap(Map.Entry::getKey, Map.Entry::getValue)); ``` to this: ``` .collect(toMap( Map.Entry::getKey, Map.Entry::getValue, (x, y) -> x, () ->...

The 2015 [comment](https://github.com/google/guava/issues/2160#issuecomment-141509099) by @cpovirk showed two places where people in Google code were comparing a value with itself. When I ran the same search again (sorry it's not visible...

> could i work on this if its available? Yes, feel free. Thanks!

As #6173 says, `ComparisonChain` is mostly obsolete. Using the static `Comparator` methods allows what's asked for here. Instead of: ``` int result = ComparisonChain.start() .compare(e1.cheapCalculation(), e2.cheapCalculation()) .compare(() -> e1.expensiveCalculation(), ()...

I do indeed have an openjdk.org account. Let me know if "submit additional info" doesn't produce the desired results and I can comment on the bug.

A user here at Google has run into a similar problem. I was able to reproduce their case by modifying the `parameterizedType()` test method in `AutoValueParcelExtensionTest` like this: ```java JavaFileObject...

This is probably better asked on Stack Overflow.

> But wait, https://www.rfc-editor.org/errata/eid5853 says that that sentence should be replaced :\ I'd have to read more to understand whether including a `charset` parameter should in fact technically be harmless....

I think @fluentfuture is indeed the expert here.