eNV25
eNV25
https://developer.chrome.com/docs/extensions/mv3/mv3-migration-checklist/
I am fine with both embedding and wrapping. I don't think it makes much of a difference in practice. If we decide to embed, we should explain that in the...
I don't think it's ready yet. While it works for Chrome, I can't test it properly for Firefox. The Firefox implementation of MV3 does have support for service workers yet....
The only thing that hasn't been resolved so far upstream is background script vs service worker. Chrome only supports service workers and Firefox only supports background scripts. If it goes...
OK, I made further changes to align to the current mv3 recommendations. `./package-firefox.sh` works without further changes to the current code. I tested it with Firefox Developer Edition using `Load...
About #108, the part in `ff2mpv.js` will need to be rewritten/rebased to support mv3 too. It should be using `chrome.contextMenus.onClicked.addListener(...)` instead of `chrome.contextMenus.create({ onclick: ... })`. The `onclick` property doesn't...
Actually the whole implementation probably needs to be re-written for mv3. Because it currently assumes that there is persistent background page. mv3 extensions use either event-driven service workers or event-driven...
We should probably be using `chrome.runtime.sendMessage()`. @DanSM-5
Here's a possible protocol for `sendMessage`: `"event"` mandatory key with the following possible values: `"createProfile", "deleteProfile", "updateProfile"`. `"data"` optional event specific data, for `"createProfile"` and `"updateProfile"` this is the new...
Once you use the correct APIs that I mentioned in `options.js` and `ff2mpv.js`, I can rebase my work here on top of that. I want to avoid touching `options` code...