Julien Chinapen

Results 55 comments of Julien Chinapen

> thanks for your pr. > @e2corporation can you help for review it? @mappjzc I'm not sure about this ticket Embeddable UI is not something we've discussed or approved in...

@mappjzc This seems like a separate UI project, why is it bundled with `incubator-devlake` project and not a new standalone project?

> No matter how to do it, it looks like we must use one config to control all the logic. I think #2862 「delete ProviderIcons and ProviderFormPlaceholders and replace them...

> Wouldn't it be better to define the properties of the field like this: > > ``` > ... > { > "authentication": "token", > "fields": [ > { >...

A Plugin does not need to be responsible for determining it's own Connection Fields at this time with regards to them being dynamically created, it should be following a standard...

> It's the first PR and ProviderConfigMap can be replaced with JSON or API requests at any time. > > In addition, my two PRS may not be merged. But...

@likyh @tk103331 I'll be making more commits as I continue ideating on the Plugin Registry concept. In the mean time, I'm fine with both of you contributing thoughts & ideas...

> Is this PR will continue now? I will be refreshing this soon, ideally other refactor PRs need to be completed or halted while I get this initial version of...

@klesh @likyh @mintsweet Phase 1 Of Dynamic **Plugin Registry** is ready for `main` branch **next** so more development & refactor can continue. Thanks.

@likyh @mintsweet All notable code review feedback items have been resolved, any additional cleanups will be deferred to a subsequent PR.