Gabriel Bota
Gabriel Bota
Based on the input I heard during the collab summit from last week that the @nodejs/loaders team is looking for more collaborators and support in implementing some of the open...
Hi @JakobJingleheimer and thanks for the reply, I work in observability domain, being part of a team working on a node.js apm solution. I have some previous contributions to node.js...
I added a testcase for a scenario where a worker thread import operation would call process.exit. I.e. - the main thread imports some module that creates a Worker thread -...
> @dygabo I think test failures in https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/35851/ might be related to this PR. > > Please take a look (after Labor Day ;o)) I'm on short vacation for the...
I pushed a fix for the failing tests when running on worker threads (at least temporary until `register` from worker is sorted out). One of the tests is fixed, the...
> Removing [ author ready](https://github.com/nodejs/node/labels/author%20ready) PRs that have at least one approval, no pending requests for changes, and a CI started. as it seems this PR adds some flakiness, which...
> Probably a separate PR, but could detect-module be a way to resolve https://github.com/nodejs/node/issues/30682? IMO that could work. As soon as detect-module will also be the default (i.e. unflagged) it...
> The more I read this, the more that I think it’s unnecessary. Now that we’ve fixed it so that registered hooks apply to all threads, I don’t think we...
> > then we should throw an error when they’re passed. That would be more effective than documentation... we tried that as part of #52706 and we decided to take...
hi @mcollina , fwiw, this was discussed on the original PR and it was decided to [implement a solution in a followup](https://github.com/nodejs/node/pull/52706#discussion_r1585144580). The _loaders work on the worker threads_. The...