Douglas Jordan

Results 11 comments of Douglas Jordan

We are hitting this as well, randomly throughout our mesh

Closed by https://github.com/istio/istio/pull/52801

@hzxuzhonghu Thanks for the quick review! Can we get this cherry-picked as well?

> Based on the context here I think you may already know this, but one note - you could, I believe, add a custom label with sourceLocality today (either with...

Aha! Matching the label selectors does indeed fix the port merging... Looks like https://github.com/istio/istio/pull/49595 is the "fix" that changed this behavior

@hzxuzhonghu Sent a fix [here](https://github.com/istio/istio/pull/51816), would love a review! We're testing this patch on top of 1.19, and it results in WLEs with locality information set correctly.

not state. Can we pass through a `validation_context` to support this? See https://www.envoyproxy.io/docs/envoy/latest/start/quick-start/securing#start-quick-start-securing-validation

> Is n't this a problem for regular sidecars as well? @ramaraochavali I think it is, right? Let's say `terminationDrainDuration` is 5min, and `drainDuration` is 45s. Presumably, a workload could...