David Blaikie

So, LLVM's philosophy here is: 1) if this is an invariant that represents a programmer error (something that should be fixed by changing some source code - either inside or...

The state of the code is less important to me than the agreement of the f18/flang community - it's something I think as a community it should be clear agreement...

> There was an objection to replacing unreachable code with assert instead of llvm_unreachable. I believe we're on the same page about llvm_unreachable for things like unhandled cases. > >...

This is the LLVM style guide's wording on assertions: https://llvm.org/docs/CodingStandards.html#assert-liberally - the examples show fairly cheap tests.

> > > There's still discussion about how to represent runtime checks that we want to always be enabled, with or without NDEBUG. NDEBUG is a big hammer that I...

Makes a fair bit of sense to the rest of the LLVM project, and I'd not be comfortable with flang being different in this regard. The requirement is to be...

are you sure this is a thing that should be SFINAE? Looks like it, but would be good to have some words from the spec that confirm it.

> > are you sure this is a thing that should be SFINAE? Looks like it, but would be good to have some words from the spec that confirm it....

Oh, I remember looking into this years ago and kind of running out of steam trying to think about all the cases/how to address them efficiently... so if anyone's interested...

ah, no, they aren't LEB128 encoded in .debug_str_offsets - they're regular sized for faster lookup (by index): https://dwarfstd.org/doc/DWARF5.pdf bottom of page 240: "This header is followed by a series of...