Dmitry Voytik
Dmitry Voytik
Hi @jodh-intel, Overall IMHO this makes sense. Btw, I guess https://github.com/clearcontainers/proxy/pull/107 still could be useful with the above plan. Although the PR should be refactored a bit. EDIT: orthography
IMHO runtime should define vCPUs default number if we consider virtcontainers as a library.
Necessary support from shim implemented in this PR: https://github.com/clearcontainers/shim/pull/54
Hi @sboeuf, No problem, I understand this. Please take your time, I don't hurry. I tested manually both patches. It works well except that hyperstart has it's own internal time-out...
@jodh-intel, thank you for the review! It seems like today I won't have enough time to address all comments thoroughly, and during next two weeks I'm on a vacation without...
@jodh-intel, thanks! :smiley:
@jodh-intel, thanks! Sorry, for delaying on the PR. I'll rework it and address the comments today after my main job. Unfortunately for the time being I can finish this only...
HI @jodh-intel, thank you! I feel responsibility to finish this anyway, so I'm going to work on the PR today evening. Sorry again for delaying this.
Hi @jodh-intel, I've update the PR. Could you please take a look at it again?
Hi @jodh-intel, thank you again for reviewing the PR! No problems with a pedantic attitude at all! Actually I value this a lot, especially when it's reasonable. All your points...