Dan Gealow
Dan Gealow
I'm working on overhauling the root cause of this problem right now, amidst some other brush-related features and fixes, at https://github.com/dvg-p4/shiny
I don't think https://github.com/rstudio/shiny/commit/fbe9d247d493c3dd33de82e6c7320c0030415aa2 *is* needed--as far as I can tell, the `resize()` function within `image.ts` just triggers the click/hover/brush handlers to clear and/or update themselves as a *consequence* of...
> (it's needed because, if the output container is stretchy, the image won't know to shrink when the container shrinks since it's size is determined by the parent) @cpsievert what...
With format set to "mm/dd/yyyy", this is arguably even worse--it'll try to set itself to the year AD 202, 20, and 2, as you try to backspace out the year.
~~On further investigation, it seems that the problem was my own darn fault. I needed to update my roxygen2 from 7.2.0 to 7.2.1, so that devtools::check() would actually redocument the...
...nope, looks like even with updated roxygen, devtools::check() still doesn't update package.json; I need to manually run `source .github/shiny-workflows/routine.sh`. Or maybe I could have just manually updated the package version....
@wch whether or not y'all accept this PR you should probably update the package.json version number on main edit: cool, looks like that's fixed
Is there a reason this hasn't been merged into master? Edit to answer my own question: yes there is, it appears that almost the entirety of the JS codebase has...
Is there a problem with that pull request from 2 years ago? Edit to answer my own question: yes there is, it appears that almost the entirety of the JS...
Nearing a workable solution that also fixes some other brush-related issues at https://github.com/dvg-p4/shiny , will be creating a pull request soon