Davide Cirillo comments

Results 15 comments of


                                            Davide Cirillo

Need a way to restore original toolbar's icon / text

At the moment you can use the MultiChoiceToolbar.Builder to specify the icon and the click listener, it'll be restored once the state is set to NORMAL. Is that what you're...

Option to deny some positions from being selected

The feature is already there, just override `protected boolean isSelectableInMultiChoiceMode(int position)` and dictate the rules. https://github.com/dvdciri/MultiChoiceRecyclerView/blob/master/library/multichoicerecyclerview/src/main/java/com/davidecirillo/multichoicerecyclerview/MultiChoiceAdapter.java#L57

Option to deny some positions from being selected

I'm gonna reopen this and take a look at this once got time, thanks

NavigationDrawer not overlapping StatusBar

Can you provide screenshots/logs? Also if you can please stick to the template of the issue and follow the headers would be great!

If updating adapter item list later on through notifyDataSetChanged, invalid state

Yes, correct, this is the issue for that. I'll be working on this soon providing a method to refresh the data set, and setting all of the item to UNSELECTED....

If updating adapter item list later on through notifyDataSetChanged, invalid state

That would be good, though i already started doing that.. so i'd say let me do this and you can review it if you want. =)

If updating adapter item list later on through notifyDataSetChanged, invalid state

I need this fix to go in master because it is also fixing some other issues. So from now on if you want to notify that the data set has...

If updating adapter item list later on through notifyDataSetChanged, invalid state

I'm gonna put that into the README documentation as well.

selectAll() selects only visible items.

I've just tried, without scrolling, calling the selectAll() and getSelectedItemCount() method it seems like all the items are selected. Can you please be more specific, add some logs or steps...

WIP: #49 handle notify data set changed and update internal list

@smarques84 Do the changes here if you can (not sure about the permissions) and add some test otherwise i'm not sure when i'll be ablet to pick this up.