Bobby Lawrence

I'm not sure what Ruby 2.1.0 would do to fix this but I can try a bit later. In the meantime, I tried 2.1.8 based on the README note "Use...

So the stuff related to bindings was actually not supposed to be part of the original PR. My intent was to only have saml2:master pull in my changes to SAML2/Assertion.php...

Looks like one other change is needed...not sure how I didn't catch this, maybe there isn't a test for it, but in SAML2/XML/saml/AttributeValue.php, the "\XML\saml\NameID" references are not correct. They...

I see there has been no movement on this PR...its been a couple months and nothing...no feedback, no approval, nothing. What can we do to get this back on track?...

> > > Hey @dub357 ! We're about to release v5 of this module and I really really really want to include this PR since it's been open for way...

> > > So looking at this now, I think perhaps I need to start over from scratch with this PR because I dont see any of the changes I...

@tvdijen So I forked your feature-friendlynames branch yesterday and starting doing some playing around. Turns out that some of the changes from my original proposed PR seem to be causing...

So I created pull request to this branch from my fork (https://github.com/tvdijen/saml2/pull/1). It fixes all the tests but I had to make a couple tweaks to Assertion, Attribute and AttributeValue...

Perhaps I'm missing something then? In the IdP metadata, the IdpSSODescriptor can have the "WantAuthnRequestsSigned" attribute which tells the SP if they want the AuthnRequest signed or not...

> > > https://docs.oasis-open.org/security/saml/v2.0/saml-metadata-2.0-os.pdf > > Paragraph 2.4.3: > > > WantAuthnRequestsSigned [Optional]Optional attribute that indicates a requirement for the samlp:AuthnRequest messages received by this identity provider to be signed....