Dylan Duan

Results 18 comments of Dylan Duan

> Hey, I had a question about this Lock and I guess varying on the answer I wanted to know if my "rewrite" of the first couple of paragraphs was...

@WhiteR4bbitt I updated the RPC with the commit: https://github.com/nervosnetwork/rfcs/pull/308/commits/345b19e0f9d3b245b983ff38106506f7bc90ac5e. But I think there are a few points to note: - Not all TYPE/DATA for cheque lock script, it depends on...

> I just was not 100% following the unlock rules, but also looking at the rust code (still learning rust) it seemed like this `Lock` would be useable with any...

> @duanyytop It would be beneficial to add requirements to the steps for the Reproducible Build. Without them, many errors will be received since it requires specific versions of a...

> > I think the [CI configure](https://github.com/nervosnetwork/ckb-cheque-script/blob/main/.github/workflows/build_and_test.yml) is enough and @jordanmack how do you feel? > > Yes, that is adequate. Just add a line that links to this and...

> Unlock Rules 1.b.i will error if the receiver is valid and a since was used on one of the inputs. It seems like the transaction would still work if...

> @duanyytop I'm rewriting part of the description for clarity. I want to make sure I understand the functionality and intent correctly. > > The Cheque Lock can match against...

> > The Cheque Lock only supports `secp256k1-blake2b-sighash-all` signature , so the sender and receiver can only use `secp256k1-blake2b-sighash-all` lock script to withdraw and claim the assets. > > When...

> 1. What is the reason for checking that a signature exists, but not actually validating the signature? If the `WitnessArgs` is not empty for `secp256k1-blake2b-sighash-all`, the signature will be...

> > If the `WitnessArgs` is not empty for `secp256k1-blake2b-sighash-all`, the signature will be verified by the receiver lock script and Cheque Lock does not need to do repetitive things....