duane

Results 12 comments of duane

@JessieQX Unfortunately, I'm not going to have time to debug this and update the code for a while, this project has had to take a bit of a back seat...

@satta I'm failing to find good references in the current Suricata [documentation](https://suricata.readthedocs.io/en/suricata-6.0.2/rules/intro.html?highlight=icmp#protocol) around support for keywords `icmpv6`, `ftp-data` etc for protocols. Can you provide a quick pointer in the source...

I think with the current revisions all of the protocol parsing issues should be resolved. network parsing issues should be resolved as well, with one caveat: We currently define `0`...

note: network parsing issues were addressed in #165

IIRC we removed support for spaces in the past, possibly because it was introducing some odd complexity in the lexer, and we noted that basically all rulesets and examples don't...

@clem1 Any thoughts here. I don't see a strong reason for this to be its own goroutine, but maybe you had given this some thought?

@julienschmidt do you want to take a look at making this change? I don't know that it gains us a lot to remove it, so I don't plan to tackle...

Hey Daniel, I suspect the bugs will be in the `String()` functions for the various components. For Network issues, it's likely to be in [0][1]. The `String()` for a `Rule`...

Hi, I'm having trouble finding the PR you're referencing to review (I don't see one here in the google/gonids repo or in your own?) Can you link me directly to...

Ah, I think it's these commits[0][1] you're looking at? These look interesting, and validation logic is always welcome (that's one of the core values this lib can provide IMO). I...