dt-rush

Code comments in examples?

1

It would probably massively improve the value of the examples if they had comments. I'd be interested in taking on some of this work and could create pull requests to...

Document bridge interfaces on-device

5

- eth0 / wlan0 - resin-dns - resin-vpn - balena0 - supervisor0 - br-xxxxxxxxx Documentation would cover: - how interface is created (links to source if possible) - what services...

Base images docs links to github are broken

3

see: https://www.balena.io/docs/reference/base-images/base-images/?ref=dockerhub#raspberry-pi-v1-zero For example, the "github" link for `resin/raspberry-pi-node` links to: https://github.com/balena-io-library/base-images/tree/master/node/raspberry-pi ... but should link to: https://github.com/balena-io-library/base-images/tree/master/balena-base-images/node/raspberry-pi

BalenaCloud docs list support for UP board, BalenaOS docs do not

2

[BalenaCloud](https://www.balena.io/docs/reference/base-images/base-images/#up-board) [BalenaOS](https://www.balena.io/os/docs/supported-boards/) (no UP!) There ought to be one source of truth.

remove unnecessary necessity of predeclared, known-at-declaration-time labelset for metrics

2

Please see discussion in #298 for context + improved validation testing Change-type: minor Connects-to: #298 Signed-off-by: dt-rush

Relax necessity of declaring labelset in advance

14

There is no inherent restriction in prometheus for this. Labels can appear or disappear from the timeseries a node exports. This restriction in this JS client appears to be a...

user-configured redirect URL clobbered in oauthproxy.go

5

see line 55 of oauthproxy.go ([link](https://github.com/bitly/oauth2_proxy/blob/a94b0a8b25e553f7333f7b84aeb89d9d18ec259b/oauthproxy.go#L155)) We literally overwrite whatever the value is with `fmt.Sprintf("%s/callback", opts.ProxyPrefix)` even if the user provided a redirect URL they want to use.

Fixed clobbering of user-configured redirectURL

1

Change-type: patch Connected-to: #677

[bandlabextractor] added new bandlab extractor for track, album, and playlist…

19

### Before submitting a *pull request* make sure you have: - [x] [Searched](https://github.com/ytdl-org/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests - [x] Read [adding new extractor tutorial](https://github.com/ytdl-org/youtube-dl#adding-support-for-a-new-site) - [x] Read [youtube-dl...

Currently, failing during parsing just leads to something like: ``` Error: match failed at .../node_modules/ometa-js/lib/ometajs/core.js:64:15 at fail (.../node_modules/ometa-js/lib/ometajs/core.js:11:20) at Object. (.../node_modules/ometa-js/lib/ometajs/core.js:16:2) at Module._compile (module.js:653:30) at Object.Module._extensions..js (module.js:664:10) at Module.load (module.js:566:32)...