Danny Strockis

Results 10 issues of Danny Strockis

Just use the B2C app itself

The DID method `ion-test` does not include a DID prefix in the `document.publicKey[i].id` or `document.publicKey[i].publicKeyJwk.kid` fields: ``` { "document": { "@context": "https://w3id.org/did/v1", "publicKey": [ { "id": "#key-1", "type": "Secp256k1VerificationKey2018", "publicKeyJwk":...

I can't use did-auth-jose without using the `HttpResolver` class from the hub-node-core package. If this is meant to be a standalone package I think some refactoring is in order. Example:...

It's weird to me that the library automatically generates an access token if one was not found on an incoming request. I think it would be nicer if getting an...

enhancement

When using did-auth-jose with RSA keys, here's how I had to use the `Authentication` class: ``` // assume I have a properly formatted jwk // convert key into dict of...

While playing with the lib I encountered less-than-helpful error messages a few times. I didn't write all of them down, but here's one example I remember: ``` "Error: JWK kid...

This is a suggestion to add support for PEM formatted keys to the library. Generating public & private keys in JWK format can be a bit cumbersome, it's much easier...

When using did-auth-jose with RSA keys, here's how I had to use the `RsaPrivateKey` class: ``` // assume we have already loaded a jwk var RsaPrivateKey = require('@decentralized-identity/did-auth-jose/dist/lib/crypto/rsa/RsaPrivateKey'); const key...

The [`main` property in this package](https://github.com/decentralized-identity/hub-node-core/blob/master/package.json#L7) references `dist/index.js`, which doesn't exist until `tsc` is run. Unfortunately when I installed the packaged via NPM, `tsc` didn't run automatically. Thus when I...