Denis Stepanov comments

Results 496 comments of


                                            Denis Stepanov

Better Annotation Handling for Return types and Type Arguments

I don't see any `@MyAnnotation` in the example

Better Annotation Handling for Return types and Type Arguments

I would expect to see any of the tested annotations in the code: ``` package test; import io.micronaut.core.annotation.Introspected; import io.micronaut.context.annotation.Executable; import javax.inject.Singleton; import java.util.List; @Introspected @Singleton class Test { public...

Better Annotation Handling for Return types and Type Arguments

Ah I see

Consider supporting Mutiny

Hibernate Reactive provides a two reactive APIs: - Mutiny - CompletionStage Micronaut Data Hibernate Reactive is using only `CompletionStage` so no Mutiny dependency is needed

Do not set CLOUD environment for GitHub runners and/or any test environment

You can disable it using `deduceEnvironment`: `Micronaut.build().deduceEnvironment(false).run()`. I think we are going to remove automatic deduction in V4.

Do not set CLOUD environment for GitHub runners and/or any test environment

Ah right, you have a test... The other way would be to disable it using a system property

CircuitBreaker should not throw the original exception when the circuit is open

Yes, we should probably keep the previous behavior and enable a new one by introducing a new parameter on `@CircuitBreaker`

CircuitBreaker should not throw the original exception when the circuit is open

@canastillo Look for the place where `CircuitBreakerRetry` is created, you can see how the annotation values are extracted.

@Scheduled `suspend fun` never runs

It doesn't make much sense to have it, we can't do anything special to block it, and probably an error message should be thrown in that case.

@CircuitBreaker cache failed result when gate open

Can you please create a sample project that reproduces it