clearPHP

clearPHP copied to clipboard

kalenpw

Assigning to array with list has changed in PHP 7.

1

I'd recommend to alter the recommendation to always sort by key rather than an array_reverse. Example: https://3v4l.org/scmZ8

frankdejonge

Avoid direct include or require in spl_autoload_register

2

In https://github.com/dseguy/clearPHP/blob/master/rules/use-smart-autoload.md example: function my_autoloader($class) { include 'classes/' . $class . '.class.php'; } For every include that fail, will generate a warning and increase your log. If you have 4...

joanhey

Two rules which are essentially the same ?

2

When going through everything, I noticed that these two are essentially the same. If they are not (supposed to be), then maybe the difference between the two rules should be...

jrfnl

Whitespace

4

Currently are all examples, pattern without space between brackets and var. I think is also a good practice to write readable code. Maybe I would check all examples for this...

bueltge

"Commented Fallthrough" examples are reversed

1

On the [Commented Fallthrough](https://github.com/dseguy/clearPHP/blob/master/rules/commented-fallthrough.md) page, the "warnings" and "legit" examples should be reversed.

victorstanciu

While you have linked to Nikita's article [Disproving the Single Quotes Performance Myth](https://nikic.github.com/2012/01/09/Disproving-the-Single-Quotes-Performance-Myth), your advice is still incredibly generalized and not entirely accurate. I wrote this up on [PHP The...

philsturgeon