clearPHP icon indicating copy to clipboard operation
clearPHP copied to clipboard

Two rules which are essentially the same ?

Open jrfnl opened this issue 10 years ago • 2 comments

When going through everything, I noticed that these two are essentially the same. If they are not (supposed to be), then maybe the difference between the two rules should be made clearer. If they are, I suggest merging them into one rule.

https://github.com/dseguy/clearPHP/blob/master/rules/no-buried-assignation.md https://github.com/dseguy/clearPHP/blob/master/rules/no-implied-if.md

jrfnl avatar May 26 '15 05:05 jrfnl

Reading through them again, I do see them as two different rules, but the distinction could still be made clearer.

jrfnl avatar May 26 '15 05:05 jrfnl

Implied-if is for using && or || as a if-then-else statement. buried assignation is for locating an assignation where one would expect only an argument.

Do you have suggestions for renaming ?

dseguy avatar May 27 '15 13:05 dseguy