David Salisbury

Results 15 comments of David Salisbury

I hit this today and dug into it a little. The exception is coming out after firing the callback; for me the callback function is ``. It doesn't appear to...

Here's the RuntimeError popping out without aiohttp in the mix: ``` import asyncio from PySide import QtGui from quamash import QEventLoop @asyncio.coroutine def run(loop, addr, port, ssl): transport, protocol =...

hey @procchio6! Thanks replying. I've raised this WIP PR to get some general feedback: https://github.com/giantmachines/redux-websocket/pull/123 let me know if you have any thoughts.

Hey hey! Another data point: this is triggering in bitbucket pipelines with a step that has a 1GB memory limit for the docker service. I can also recreate it reliably...

I noticed that there's a new bugfix release of tomlkit (0.11.3) about 30 mins ago but it hasn't made any difference here

This is an issue that I've faced too -- and I found a sneaky solution for it. In `NestedMixin.__init__`, I saw that it calls `self.nest_prefix = something_somethingelse`, so what if...

~So one thing I have outstanding is detecting the current default IngressClass (as per https://kubernetes.io/docs/concepts/services-networking/ingress/#default-ingress-class)~ ~Here's my thinking:~ 1. ~in the setup of source/ingress.go, load the IngressClasses, find any with...

Update on things: 1. detecting default ingress class isn't necessary; if there's a default and a new ingress is created with no class name set, the admission controller sets it...

I think this is ready for review! I've done some manual verification locally with a kind cluster connected to pdns in the following scenarios: * two `IngressClass` defined (with one...

> @dsalisbury Can you rebase this PR? or if you have no time for it i can do it and create separate PR Yep, all done!