ds-martinso comments

Results 5 comments of


                                            ds-martinso

Why is auto scrolling not scoped within the DragDropContext?

Please see this example for more clarification on what I mean: Why is my table scrolling up when I want to drag horizontally? (First scroll the table a bit down,...

Safari: Dragging outside of the table to scroll sideways does not work

Hi @patricktran Out of curiosity, will you add the automatic scrolling functionality for other browsers than Chrome?

Changing the actual draggable columns after first render, does not work.

Hi @patricktran Thanks for the reply, and great to see that you are back. I will be moving to react-table v7, so this library is no longer of use to...

Request to be able to decide whether a reorder should be done.

For example, this would be perfect to have: ```javascript ... _draggableColumns$sr = draggableColumns.shouldReorder, shouldReorder = _draggableColumns$sr === undefined ? defaultProps.shouldReorder : _draggableColumns$sr ... if (shouldReorder) { // run all reorder...

Request to be able to decide whether a reorder should be done.

Interesting, good to know! I am not sure what the correct solution is, but I created this PR and it works for me: https://github.com/patricktran/react-table-hoc-draggable-columns/pull/27 (The author does not seem to...