Drew Powers

Results 8 comments of Drew Powers

šŸ‘‹šŸ» Hi! (I work with @bschlenk and he’s out for a while) > My understanding is that we should either remove "type": "module" from the package.json, but I don’t know...

> Would you mind doing a code review to see if I didn’t mess up anything? It’s mostly important that we don’t cause any breaking change. šŸ˜… Oh so on...

Opened a PR here: https://github.com/KittyGiraudel/a11y-dialog/pull/701 because I don’t know how to open a PR against this one. But you get the gist (you can just cherry-pick the commit; I don’t...

> What we can also do if that’s easier is to assume this change cannot safely be done in a minor, and plan it for v9. Oh also just FYI:...

This is actually a common misconception about how `discriminator` works—**the mapping is optional** and it’s actually designed to automatically infer to the `propertyName` without the mapping. [See a more detailed...

So Terrazzo does support [color-scheme](https://terrazzo.app/docs/cli/integrations/css/#color-scheme) already; would this conflict with that? --- > My first question isn't about Terrazzo generating the code, but having the dataset to do so (directly...

Great catch! I’m a little embarrassed I didn’t notice this. Yes any/all improvements here are welcome (and we can also open issues on Rolldown too. Rollup did do a better...

I think the named exports (#100) is actually a better solution than default export. The problem with exporting an object is that object will persist in the final bundle, and...