William Chou
William Chou
Re: Puppeteer vs. Webdriver, I'd also keep an eye on test execution speed and reliability/flakiness. E.g. it's possible that the additional coverage is not worth the CI brittleness introduced, especially...
A slightly easier variant would be to support output of a single page in the story as a flat image for export (vs. compiling the entire story experience into a...
Seems reasonable to use h1, h2, h3 etc. for text presets and text sets. I don't think we need to bother with quantity restrictions. IMO this is a P3/P4 though.
@ampproject/wg-ads Another affiliate marketing component FR.
+1 to integrating with `amp-link-rewriter`. Analytics should interface with `amp-analytics`.
> We have starting replicating our JS in the new extension, using the AMP components which you guys have mentioned for link-swapping and analytics events. Is there any process to...
See schedule here: https://github.com/ampproject/amphtml/blob/master/contributing/design-reviews.md
Validator errors typically don't have extension-specific language. What if we added nuance to the console warning? "JavaScript size and script hash requirements are disabled in development mode (development mode is...
Hehe, option (3) was actually the original state -- `amp-script[development]` was the invalid attribute that skipped the hash check, which was later merged into `data-ampdevmode`. More context in #24987. I...
Yea, it seems like the best option.