drawlinson

Results 17 comments of drawlinson

--ignore-ssl-errors option passed to phantomjs

Also request this option. I will post a fix if I find it.

Improvement documentation | Refutation results

Hi all. I would he happy to contribute to the docu, if I can. I actually tried to answer this question myself, in note form here: https://github.com/py-why/dowhy/issues/929 If this is...

Causal Graph not provided. DoWhy will construct a graph based on data inputs.

This message is normal when you don't provide an explicit graph. Instead, DoWhy tries to construct a graph based on your arguments specifying treatment, outcome and confounding variables.

Inconsistent encoding with pandas get_dummies causes prediction and effect estimation errors

PR here https://github.com/py-why/dowhy/pull/1112

Inconsistent encoding with pandas get_dummies causes prediction and effect estimation errors

I think this is resolve with merge of PR 1112 . However, its also an option to remove use of get_dummies entirely if this is considered desirable, using the same...

Inconsistent encoding with pandas get_dummies causes prediction and effect estimation errors

I'll get onto that ASAP!

Inconsistent encoding with pandas get_dummies causes prediction and effect estimation errors

@amit-sharma PR now available to complete the job... https://github.com/py-why/dowhy/pull/1135

Inconsistent encoding with pandas get_dummies causes prediction and effect estimation errors

Resolved with PR #1135

Replace all occurrences of get Pandas' get_dummies() with skLearn OneHotEncoder

hi @amit-sharma are you able to take a look at this one? Thanks!

Replace all occurrences of get Pandas' get_dummies() with skLearn OneHotEncoder

@amit-sharma I added some tests which aim to verify that encoding is consistent despite permuting data row order. It was a bity tricky working within the interfaces of the Estimator...