David Allsopp

Results 163 issues of David Allsopp

Silences the alert proposed in ocaml/ocaml#11198, but this PR can be merged regardless.

Tighter alternative to #11361. Tested on my fork, so opening a PR to ocaml/ocaml adds an additional test. In theory, this PR: - Removes all privileges from the `GITHUB_TOKEN` in...

no-change-entry-needed

This is a follow-on for #11343: if we stop committing `configure`, we should ensure that it doesn't accidentally (or nefariously) get recommitted. There was one place in the testsuite where...

no-change-entry-needed

There've been a couple of PRs recently where the lack of Windows CI has hurt a bit. With the number of things going on in the runtime, it's particularly useful...

no-change-entry-needed

Minimum version moves with the GitHub Actions runners supported version on Ubuntu. The Ubuntu 22.04 runner on GitHub action is in beta at the moment, but we only need to...

While trying to close down some other PRs, I hit problems with the mingw-w64 locale mangling in runtime/floats.c This PR attempts to bring a little more order to it (and...

905d17c95ddadfc919d34ef156f656bde8939b55 removed `caml_print_trace`, but left the references to `DbgHelp`. 666a1f27165ac2be1febfed28a66e403fd787745 removed `caml_time_counter`, but not the associated support code for it in `caml_init_os_params`. The version of `caml_time_counter` added in #10964 is...

no-change-entry-needed

The GitHub Actions received a very welcome overhaul from @Engil as part of the multicore effort. There are a few things which can still be worked on (and a couple...

The UTF-8/UCS-2 conversion functions assume null-terminated strings on the OS side, but this isn't the case for some functions in the Windows API. In this case, `caml_stat_strdup_to_utf16` returns an `LPWSTR`...

Apropos https://github.com/ocaml/ocaml/pull/11353#issuecomment-1165585708, we should experiment with `%.17g` for `string_of_float`.