Khanh Duong

Results 23 comments of Khanh Duong

I would love to join slack group. About the `test_get_constraints_from_deps `, I tested in my laptop, it passed all 7 cases. The packages template `"FooProject": {"path": ".", "editable": "true"}` I...

The requirements file generated by the old command is definitely a bug, environment variables should not be expanded. But according to [pipenv doc](https://github.com/pypa/pipenv/blob/main/docs/advanced.rst#-injecting-credentials-into-pipfile-via-environment-variables), ``pipenv`` supports for both ``$VARIABLE`` and ``%VARIABLE%``,...

`pip` want requirements file could be platform independent and could be used inside URL, so it only supports POSIX format with UPPERCASE. There's a discussion about that https://github.com/pypa/pip/pull/3514. Should `pipenv`...

This should be fixed with new version of `pipdeptree`. https://github.com/tox-dev/pipdeptree/blob/main/CHANGES.md#230

Inside `pip_install_deps`, we call `get_source_list` with `index=None` and `extra_indexes=None` https://github.com/pypa/pipenv/blob/9572c319fd3eed0eece9bb1ee6a8ace107e4f8fc/pipenv/core.py#L1638-L1643 Therefore `get_source_list` will get source from `Pipfile` instead of `Pipfile.lock` (line 91) https://github.com/pypa/pipenv/blob/9572c319fd3eed0eece9bb1ee6a8ace107e4f8fc/pipenv/utils/indexes.py#L68-L98

To address this issue, there's a fix that is throwing all the indexes written inside Pipfile.lock into `index` and `extra_indexes` from the call of `get_source_list`. But in that case, all...

`pipenv lock --requirements` locking before printing out requirements, `pypi-mirror` could be checked. Since the new `pipenv requirements` doesn’t rely on locking, it just get ouput from `Pipfile.lock`, it might be...

I think there is an alternative solution that is : `pipenv lock --pypi-mirror` should write `pypi-mirror` into `Pipfile.lock`. Then `pipenv requirement` could use that mirror since it’s written in `Pipfile.lock`.

`pipenv requirements` have to resolve dependencies to generate correctly requirements. It should either resolve by itself, or depend on `Pipfile.lock`, so locking before generate requirements makes sense. Even if we...

> How about something like this? > > ```python > if Path(line).is_file(): > return line > return finder.find_python_version(line) > ``` It's already had, but with absolute path: https://github.com/pypa/pipenv/blob/897caca7752a9d2d648ccb3407aca30bd7962941/pipenv/utils/shell.py#L288-L291 Should this...