David P. Sanders

No 5 incorrect on README

1

I don't see how to suggest a PR. Number 5 is missing a semi-colon: ```jl julia> Z = [10:99] # wrong 1-element Vector{UnitRange{Int64}}: 10:99 julia> Z = [10:99;] # correct...

Fix examples to import the package correctly

2

Replace the (wrong)`include` with a correct `using` statement in this and other examples: https://github.com/AnderGray/ProbabilityBoundsAnalysis.jl/blob/652700c7d2e1853f189b463d0786fd2f3c467f16/examples/simple.jl#L1

Store global variables in a `const` structure

2

Using global variables as in https://github.com/AnderGray/ProbabilityBoundsAnalysis.jl/blob/652700c7d2e1853f189b463d0786fd2f3c467f16/src/ProbabilityBoundsAnalysis.jl#L70 is a [performance trap](https://docs.julialang.org/en/v1/manual/performance-tips/#Avoid-global-variables). To fix this, I suggest grouping all the global variables into a `mutable struct`, which you refer to via a...

Include LICENSE for the original R package

2

I think (part of?) the license for the original R package needs to be included somehow in the `LICENSE` file, or at least mentioned. I'm not familiar with the rules...

Clashes with `Plots.jl`

2

My default graphing library is `Plots.jl`, but PBA clashes with it: ```jl julia> a = uniform(0, 1) Pbox: ~ uniform ( range=[0.0, 1.0], mean=0.5, var=0.083333) julia> using Plots julia> plot(a)...

Make `shape` a type

1

It would be more "Julian" to make the shape of a pbox into a type, e.g. `Normal()`, `Uniform()`, etc. https://github.com/AnderGray/ProbabilityBoundsAnalysis.jl/blob/652700c7d2e1853f189b463d0786fd2f3c467f16/src/pbox/pbox.jl#L62 Part of the review for the JuliaCon proceedings: https://github.com/JuliaCon/proceedings-review/issues/96

Feature request: Presentation mode

35

It would be fantastic to have a presentation mode like RISE for Jupyter notebooks: https://rise.readthedocs.io/en/stable/ Basically it would convert the notebook into a live presentation.

Add name to a Bond

8

Now we have the possibility of having the value next to a slider -- great! It would be useful to have the name of the variable too.

Symbolic expansion broken in Newton notebook 1.6

1

@fonsp: Symbolic expansion isn't working on the published version. Maybe it just needs regenerating with a current version of Symbolics.jl?

Need for modern formatting of docstrings in inline `help(something)` and in separate `something?` window

22

With the styling of the Notebook being in general so sleek and modern, and more so with upcoming CSS mods, there is one aspect of the look and feel that...