Dhairya Parmar

Results 114 comments of Dhairya Parmar

> @dparmar18 @kotreshhr from @djgalloway "Rebase on #47625 to resolve API failure" I've rebased. Thanks. I hope it passes now.

> > @dparmar18 How are you testing this fix? > > There needs to be a QA test before this can be merged. One tests that a client is evicted...

@batrick So you mean to say > > > > @dparmar18 How are you testing this fix? > > > > > > > > > There needs to be...

> > @batrick So you mean to say > > > > > > @dparmar18 How are you testing this fix? > > > > > > > > >...

@batrick I was thinking to do something like adding `CEPH_MDS_OP_DUMMY = 0x01600` in `src/include/ceph_fs.h` and then send it to the MDS and make sure MDS didn't crash. What do you...

> Okay, so we really just need to audit every time we call "abort" in the MDS code. Server::reclaim_session has one that needs work You've changed handle_client_session. _session_logged has a...

@batrick `Server::handle_client_reclaim` and `Server::handle_client_session` do handle client's message. Good to change it then, Maybe in a separate PR?

looking to remove `ceph_abort()` statement and implement something better at: 1. https://github.com/ceph/ceph/blob/main/src/mds/Locker.cc#L4249 - ceph_assert(m->get_source().is_client()); happens at [#L4189](https://github.com/ceph/ceph/blob/main/src/mds/Locker.cc#L4189), so the switch case must be getting actions from a client, if this...