Frederic Ruget

> fix #239 > (add subtitles for video feature #239) > > Generate HTML5 subtitle tracks dynamically based on the contents of the folder > where the video is located....

[ Intermediate status report ] Hi @skjnldsv and @beardhatcode. I believe I have gathered most of the pieces I will need to implement the requested changes and I am now...

One question still: From OCP\IL10N I can retrieve a list of abbreviated language names (e.g.: en, fr). However I was not able to retrieve the unabbreviated language names (e.g.: English,...

> > Currently I have three new/modified files: > > You can push them, so we can review and comment :) OK. I'll try and push later today.

I have just pushed to feat/video-caption. The code is refactored and working :) A couple of questions as comments in 'VideoController.php' -- about @nnotations (I don't understand what they do)....

@beardhatcode @skjnldsv I suppose we want some non-regression test to be added to viewer's automated test suite? Maybe we can setup a mini video folder, have viewer "render" the video...

@beardhatcode @skjnldsv what about user documentation? Should the feature be mentioned in the Github's README for the viewer?

Hi @skjnldsv Indeed captions would be a nice addition to the viewer. And it seems we could leverage plyr.io support for HTML5 captions to provide the feature at a low...

I just tested the patch below. Does quite a decent job. I might send a pull request? ``` diff --git a/src/components/Videos.vue b/src/components/Videos.vue index 727939b..007c203 100644 --- a/src/components/Videos.vue +++ b/src/components/Videos.vue @@...

> Plyr.io supports only .vtt (its more like HTML5 thing) > https://github.com/maple3142/GDIndex > > The above index, has support for .srt files too. Actually, pull request #915 will provide .srt-like...