Doug Nazar

Results 18 comments of Doug Nazar

Basically lifecycle-2.5.0-alpha01 added a new preferred create() method to ViewModelProvider.Factory that takes an additional CreationExtras parameter. LeakCanary's ViewModelClearedWatcher https://github.com/square/leakcanary/blob/79cdab733e1fc2652384e976778c1807537f71d6/leakcanary-object-watcher-android-androidx/src/main/java/leakcanary/internal/ViewModelClearedWatcher.kt#L47 doesn't implement this yet, and due to some optimization quirk (I...

So I first verified that adding that method to [ViewModelClearedWatcher](https://github.com/square/leakcanary/blob/79cdab733e1fc2652384e976778c1807537f71d6/leakcanary-object-watcher-android-androidx/src/main/java/leakcanary/internal/ViewModelClearedWatcher.kt#L47) does _solve_ this issue for me and I'll be using that as a temporary measure. I then spent way too...

I believe this is on purpose. LeakCanary seems to go out of its way to not pull in dependencies that might not be used/wanted. Which was great until this issue...

So this seems to be working for me: ``` diff --git a/leakcanary-android-core/build.gradle b/leakcanary-android-core/build.gradle index b13a607a..b8055888 100644 --- a/leakcanary-android-core/build.gradle +++ b/leakcanary-android-core/build.gradle @@ -7,7 +7,6 @@ plugins { dependencies { api projects.sharkAndroid...

Can you recreate the crash with 1.36.21 and send the updated backtrace. Thanks.

I am a bit worried it would lead to bikeshedding. I think you can set it when checking to not error for certain formatting issues. Another option is to just...

So here is the above listed files (skipping test). I've adjusted it to 100 columns, and adjusted the include ordering, although I don't think I can group the conditional includes...

I've pushed that change as a diff to make it easier to review. I'll rebuild the pull request based on **master** when ready.

Strange, I tested on my Gentoo system & a Ubuntu VM (I don't have mine anymore, but here's the version from the original issue). What I also don't like is...