Ewan Douglas

re-importing modules breaks fresnel propagation

3

@mperrin, I found the bit of code that was breaking coronagraph sims during benchmarking. This is an edge case, but running the following snippet to reload modules after importing causes...

Anti-aliased apertures needed to increase numerical accuracy

4

As discussed in #106, 'gray' aperture edges, would decrease high-order aliasing and allow one-to-one comparison of POPPY Fresnel systems (#103, #108) with their PROPER equivalents.

unexpected ZernikeWFE.get_opd() behavior

7

Kudos to @tukyab for helping find this one. setup of problem: ``` r=.0254 osys = poppy.OpticalSystem() osys.add_pupil(poppy.CircularAperture(radius=r)) osys.add_pupil(poppy.ZernikeWFE(radius=r,coefficients=[0,0,0.000001,0])) ``` Expected behavior: ``` plt.imshow(osys.planes[1].get_opd(osys.input_wavefront(wavelength=600e-9))) plt.colorbar() ``` gives:  unexpected behavior: ```...

DET_OVERSAMP header keyword does not return detector oversampling

1

When the MFT detector sampling is not equal to the wavefront oversampling the correct value is not passed to the output FITS file header. Example code: ``` osys = poppy.OpticalSystem(oversample=18)...

As discovered recently by @neilzim and as [previously](https://github.com/douglase/poppy_example_notebooks/blob/master/Fresnel/Microscope_Example.ipynb) noted but not documented, the current way plate scales are calculated in the fresnel wavefront class depends on the focal length attribute...

I have code for fitting zernike's with scipy optimizers to noisy data. I will put something together to compare that to the simpler decomposing function that already exists in POPPY...

Examples not running on Python 3.6

1

The following code works in Python 2.7 on in macOS 10.13: ```n=4096 y=np.ones([n,n]) x=2*np.ones([n,n]) z=1 out=np.ones_like(x) @hope.jit def hope_exp(X,Y,Z,A): A[:] = hope.exp((X**2+Y**2)/Z) hope_exp(x,y,z,out) ``` but in Python 3.6.1 it returns...

fresnel propagation test test_fresnel.test_Circular_Aperture_PTP_short fails for recent skimage versions

2

Paging @douglase... Maybe you might recall something helpful about this puzzle. In testing @kian1377's CuPy GPU enhancement of poppy, I've discovered that the test `test_fresnel.test_Circular_Aperture_PTP_short()` is failing, not just on...

If .pro contains a stop, figures don't show up until another cell is executed

1

Thanks for putting this together, great idea, install was easy and so far it's working great. A small thing I've noticed, whenever I hit a stop in a procedure, the...

General DM class

4

@mperrin this has been sitting in my branch for over a year but has come in handy so I though'd put in a PR. Thoughts? I think @neilzim may have...