Doug Brunner comments

Results 6 comments of


                                            Doug Brunner

(ios) fixed no initial notification

Bump: can this be merged in soon?

Electron 9 error message, non Context-Aware module, worker threads

Now that `node-hid` is using N-API, can this issue be closed?

Electron 9 error message, non Context-Aware module, worker threads

OK, so the change to N-API didn't lead to creating multiple library contexts as would be needed to close this out. Thanks for the clarification.

ble.disconnect() should not call the connect failure callback

@don - unfortunately this re-breaks `@ionic-native/ble`'s transformation of the callbacks from `connect` into an `Observable`. It looks like I previously had fixed it with 84a8219. If the error callback never...

ble.disconnect() should not call the connect failure callback

@don - I had that same thought when I read through the `ionic-native` code at first. However, according to the [documentation](https://github.com/ionic-team/ionic-native/blob/master/DEVELOPER.md): > clearFunction is used in conjunction with the observable...

ble.disconnect() should not call the connect failure callback

@don I agree that it doesn't seem right for the `Observable` to terminate with an error when there wasn't actually an error. Ideally there would be a third callback on...