eventsource

eventsource copied to clipboard

Client will hang there if the server side crashed after the connection has already been established.

2

Let's see the example below: **Server side:** ```golang package main import ( "fmt" "net" "net/http" "time" "github.com/donovanhide/eventsource" ) type TimeEvent time.Time func (t TimeEvent) Id() string { return fmt.Sprint(time.Time(t).UnixNano()) }...

breezelxp

Wait for stream writes to stop before closing channels

3

I was getting some test failures under the race detector after calling `stream.Close`. The goroutine that processes events was writing to the channel that `Close` closed. It looks like the...

pboyd

maxifom

CloseNotify() is deprecated

1

Unfortunately, CloseNotify() is deprecated: "Deprecated: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead." (https://golang.org/pkg/net/http/#CloseNotifier)

perpetual-hydrofoil

After call stream.Close(), panic: send on closed channel

1

Error line: stream.Errors

debugsucks

Make initial/max retry duration configurable

1

this closes #40

ThiefMaster

Currently the duration keeps increasing, and after a while of server downtime the client will be unusable since it'll take ages for it to retry. Both the initial and maximum...

ThiefMaster

a thread safe close method

4

Currently, there are several issues with the library. 1. `Close` is not thread safe. the `isStreamClosed` cannot protect a gorouting sending to a panic panel. ref: #33 2. Socket leaks....

iandyh

Check if a stream is closed just before writing to the stream channels

7

I ran into this issue a few times this morning. I was getting panics on writes to closed channels because the initial closed check passed in the loop but once...

aphistic

fix go vet and go test -race

4

Here are a few fixes to satisfy go vet and test. I'm running these on circleci. We use them regularly and it might be worth enabling them for this repo...

ashanbrown